Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includes for <boost/foreach.hpp>. Resolves PR #5. #6

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

warnes
Copy link

@warnes warnes commented Jan 17, 2022

Resolves errors about missing definition for BOOST_FOREACH described in PR #5:

make -j14
[  5%] Built target doxygen_target
Scanning dependencies of target gnuradio-osmosdr
[ 20%] Built target pygen_apps_99d5b
[ 25%] Built target pygen_python_4b7cb
[ 28%] Built target pygen_apps_2f344
[ 28%] Built target osmosdr_grc_yaml_blocks
[ 34%] Building CXX object lib/CMakeFiles/gnuradio-osmosdr.dir/source_impl.cc.o
[ 34%] Building CXX object lib/CMakeFiles/gnuradio-osmosdr.dir/sink_impl.cc.o
/media/psf/inoui/src/gr-osmosdr/lib/sink_impl.cc: In constructor ‘sink_impl::sink_impl(const string&)’:
/media/psf/inoui/src/gr-osmosdr/lib/sink_impl.cc:250:29: error: expected primary-expression before ‘*’ token
  250 |   BOOST_FOREACH( sink_iface *dev, _devs )
      |                             ^
/media/psf/inoui/src/gr-osmosdr/lib/sink_impl.cc:250:30: error: ‘dev’ was not declared in this scope; did you mean ‘div’?
  250 |   BOOST_FOREACH( sink_iface *dev, _devs )
      |                              ^~~
      |                              div
/media/psf/inoui/src/gr-osmosdr/lib/sink_impl.cc:250:3: error: ‘BOOST_FOREACH’ was not declared in this scope; did you mean ‘BOOST_CATCH’?
  250 |   BOOST_FOREACH( sink_iface *dev, _devs )
      |   ^~~~~~~~~~~~~
      |   BOOST_CATCH
/media/psf/inoui/src/gr-osmosdr/lib/sink_impl.cc:251:31: error: ‘dev_chan’ was not declared in this scope
  251 |     for (size_t dev_chan = 0; dev_chan < dev->get_num_channels(); dev_chan++) {
      |                               ^~~~~~~~
/media/psf/inoui/src/gr-osmosdr/lib/source_impl.cc: In constructor ‘source_impl::source_impl(const string&)’:
/media/psf/inoui/src/gr-osmosdr/lib/source_impl.cc:198:32: error: expected primary-expression before ‘arg’
  198 |      BOOST_FOREACH(std::string arg, arg_list) {
      |                                ^~~
/media/psf/inoui/src/gr-osmosdr/lib/source_impl.cc:198:6: error: ‘BOOST_FOREACH’ was not declared in this scope; did you mean ‘BOOST_CATCH’?
  198 |      BOOST_FOREACH(std::string arg, arg_list) {
      |      ^~~~~~~~~~~~~
      |      BOOST_CATCH
/media/psf/inoui/src/gr-osmosdr/lib/source_impl.cc:424:31: error: expected primary-expression before ‘*’ token
  424 |   BOOST_FOREACH( source_iface *dev, _devs )
      |                               ^
/media/psf/inoui/src/gr-osmosdr/lib/source_impl.cc:424:32: error: ‘dev’ was not declared in this scope; did you mean ‘div’?
  424 |   BOOST_FOREACH( source_iface *dev, _devs )
      |                                ^~~
      |                                div
/media/psf/inoui/src/gr-osmosdr/lib/source_impl.cc:424:3: error: ‘BOOST_FOREACH’ was not declared in this scope; did you mean ‘BOOST_CATCH’?
  424 |   BOOST_FOREACH( source_iface *dev, _devs )
      |   ^~~~~~~~~~~~~
      |   BOOST_CATCH
/media/psf/inoui/src/gr-osmosdr/lib/source_impl.cc:425:31: error: ‘dev_chan’ was not declared in this scope
  425 |     for (size_t dev_chan = 0; dev_chan < dev->get_num_channels(); dev_chan++) {
      |                               ^~~~~~~~
make[2]: *** [lib/CMakeFiles/gnuradio-osmosdr.dir/build.make:76: lib/CMakeFiles/gnuradio-osmosdr.dir/sink_impl.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [lib/CMakeFiles/gnuradio-osmosdr.dir/build.make:63: lib/CMakeFiles/gnuradio-osmosdr.dir/source_impl.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:375: lib/CMakeFiles/gnuradio-osmosdr.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

rtucker and others added 11 commits February 6, 2021 17:50
Instead of guessing, query the device to populate _gain_mode and _gain.
Currently Clang fails to compile RTL TCP and bladeRF on OSX because C++ 11
features are not avaiable.
If only one device has been found, append the global numchan to the single
device's make function by passing it in as nchan. This reduces the need to
manually add the device name and append nchan; in this case nchan can now be set
from the UI dropdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants